Use preconcatTree hook for filterInitializers#24
Use preconcatTree hook for filterInitializers#24simonihmig wants to merge 1 commit intoember-fastboot:masterfrom
Conversation
|
I tried this branch using Ember CLI 2.14.0-beta.1 and it doesn't work, not sure if that hook was removed from Ember CLI or not. |
|
@josemarluedke thanks for testing. As https://github.com/ronco/fastboot-filter-initializers does not mention anything special, I assumed this would work. But it seems ember-cli does not provide this hook, this comes form ember-cli-fastboot monkey patching it: https://github.com/ember-fastboot/ember-cli-fastboot/blob/e890b45f474fb3a05c5d5b0203daa2cb63447dcb/lib/ext/patch-ember-app.js#L40. So while this should work in a FastBoot enabled (pre 1.0) app, I don't see how that proposed setup using Will try to find a better solution, or better first find out why this stopped working for me with ember-cli 2.13... |
|
Closing this as its is superseded by #21 |
When upgrading an app to ember-cli 2.13, the FastBoot support of this addon stopped working. I noticed it used the
treeForApphook instead ofpreconcatTreeto apply thefilterInitializers. Changing that fixed the problem.This is a quick fix until #21 lands...