You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So I think ember-cli-addon-tests based testing has still its valid use cases, though when you can do the same using the dummy app, that is certainly preferable...
@simonihmig I think we can run ember-cli-fastboot test atleast using the dummy addon. Other addons may need to write FastBoot tests with testing against ember canary but we need to re-work the testing strategy in general. It is extremely slow and fragile to write tests using ember-cli-addon-tests since the copy and linking on npm packages and creating app takes a long time. Morevoer yarn doesn't work as well. Agreed we need a solution for addons but we need to make ember-cli-addon-tests fast first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides some explanations on how to test addons for FastBoot compatibility, including useful addon links.