Add a link to edit the current page on github#89
Open
sdhull wants to merge 2 commits intoember-fastboot:mainfrom
Open
Add a link to edit the current page on github#89sdhull wants to merge 2 commits intoember-fastboot:mainfrom
sdhull wants to merge 2 commits intoember-fastboot:mainfrom
Conversation
Contributor
Author
|
@kratiahuja @locks would be happy to change my approach or whatever you suggest 😄 |
Adding .nvmrc file is a noop for people who don't use nvm. But for those of use using nvm, declaring the target version of node for this project is very helpful.
Appropriates the pencil svg from Ember API docs. Sends users to the `/edit/master` github page for the current markdown file in a new window.
sdhull
force-pushed
the
add-link-to-github
branch
from
42af332 to
a476a09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #88
I basically emulated what is done on the Ember API docs pages, including copying the SVG pencil icon from those pages (though I stopped short of providing a popover with the title).
For example, this is the link from the Quickstart page.