Allow html attributes#180
Merged
rwjblue merged 1 commit intoember-fastboot:masterfrom May 27, 2018
SergeAstapov:html-attributes
Merged
Allow html attributes#180rwjblue merged 1 commit intoember-fastboot:masterfrom SergeAstapov:html-attributes
rwjblue merged 1 commit intoember-fastboot:masterfrom
SergeAstapov:html-attributes
Conversation
Contributor
Author
|
Hi @kratiahuja! Do you mind to take a look once get a chance? Do you feel this is right way to approach the problem? |
Contributor
|
This would be a great addition for using lang attribute on HTML element 👍. |
Member
|
Sorry for the delay here! Merged and released as 1.2.0... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SimpleDOM document that gets created during fastboot rendering has a html tag, and it's possible to set attributes on it. For example, assuming getDOM from ember-wormhole:
But this doesn't actually cause any output in fastboot, because the user's own tag from index.html is always used instead.
This PR allows attributes set on the SimpleDOM html to be copied into the output.
Credit to @ef4 for inspirational PR #171.
Closes ember-fastboot/ember-cli-fastboot#331