Fix invalid syntax with deferRendering.#250
Merged
rwjblue merged 1 commit intoember-fastboot:masterfrom Nov 1, 2019
Merged
Conversation
An earlier refactor (to avoid floating the passed in `promise`) introduced invalid syntax (`Promise.all(firstThing, secondThing)`), this fixes the issue and adds tests ensuring we don't regress.
kratiahuja
approved these changes
Nov 1, 2019
Contributor
kratiahuja
left a comment
kratiahuja
left a comment
There was a problem hiding this comment.
LGTM, thank you for making the changes so quickly and adding tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An earlier refactor (to avoid floating the passed in
promise) introduced invalid syntax (Promise.all(firstThing, secondThing)), this fixes the issue and adds tests ensuring we don't regress.