Append extra classes to existing ones in the body and html tags#268
Merged
kratiahuja merged 5 commits intoember-fastboot:masterfrom Apr 7, 2020
Merged
Append extra classes to existing ones in the body and html tags#268kratiahuja merged 5 commits intoember-fastboot:masterfrom
kratiahuja merged 5 commits intoember-fastboot:masterfrom
Conversation
cibernox
force-pushed
the
fix-double-class-bug
branch
from
7ef8733 to
c1454ef
Compare
Contributor
Author
|
@snewcomer this should fix our bug |
snewcomer
approved these changes
Mar 25, 2020
Contributor
snewcomer
left a comment
snewcomer
left a comment
There was a problem hiding this comment.
Wow! This was a really nice implementation. Noticed a rogue file here fyi...
cbroeren
reviewed
Mar 25, 2020
test/fastboot-test.js
Outdated
| }); | ||
| }); | ||
|
|
||
| it('appends classes correctly even when there was no classes in the original html', function() { |
There was a problem hiding this comment.
Is this something you want to test for the html classes as well?
Contributor
Author
There was a problem hiding this comment.
Added another test. Good point.
Contributor
Contributor
|
Lgtm! |
Contributor
Author
|
Great, if there is anything else I must address to merge this please let me know. |
Contributor
|
Sorry forgot to click merge last night. |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, if users added classes dynamically to the body or html tags, and those tags already had any class defined, the resulting HTML would be:
which is obviously invalid. Classes are afaik the only html attribute that we want to concatenate instead of just blindly appending, so I added special treatment for the class attribute only.