Merged
Conversation
(cherry picked from commit 08538ca)
(cherry picked from commit d197631)
(cherry picked from commit 9745a4b) # Conflicts: # package.json # yarn.lock
Without these, the app wouldn't even boot properly, because it was using the decorators in a way that *other* updates found disagreeable. And hey: it gets us an update we want anyway!
A switch to npm (or Yarn 3 or pnpm) would all be good moves, but will also require updating the CI config. For the sake of being able to make consistent progress on upgrades, simply keep using Yarn for this piece.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a starting point for getting the app fully up to date, this cherry-picks in the relevant changes made in #815, then layers on a further update to
ember-concurrencyrequired to get the app to actually run its tests locally. Future PRs will pick off other updates to incrementally land.