Using latest version breaks previous working markdown files

[josemarluedke]

I was using version 0.6.13 and then upgraded to 0.6.14 and my markdown files stopped working on inline code blocks.

Here is the markdown we encountered the error.

It seems that all the content after the code block in Creating an Instance got transformed into the code block itself, not rendering the remaining of the content.

[dfreeman]

Thanks for the report, @josemarluedke, and sorry about the regression!

This change seems likely to be your culprit. Off the cuff I'd guess that those regexps need to be multiline-aware to work with the snippet you linked, but the larger issue here is that we're trying to interleave two mostly-unrelated languages using tools that only know about one or the other.

I think we're likely to continue playing whack-a-mole with issues like this until someone cooks up a parser that's aware of both Markdown and Glimmer syntax and can handle their interplay. That sounds like the kind of project I could pretty easily get nerd-sniped by, but unfortunately I don't think I'll have the capacity to take it on any time soon 🙁

[mixonic]

I've also seen this on a minor version bump with the error:

Closing tag `p` (on line 49) without an open tag.

When compiling this file.

[Exelord]

I also got into this issue. The problem is with using angle bracket components with no args. eg:

<My::Header>
  This will raise an error
</My::Header>

<My::Header @with="arg">
  This will work
</My::Header>

[bitwolfe]

Any progress on this? Latest release (v0.6.16) still causes the error

Closing tag `p` (on line X) without an open tag.

It seems to happen on all self-closing tags in combination with something as simple as having a capital letter anywhere in a tag, even in class names.

This doesn't work:

{{#docs-demo as |demo|}}
  {{#demo.example name="example.hbs"}}
    <hr class="inputClass" />
  {{/demo.example}}

  {{demo.snippet "example.hbs"}}
{{/docs-demo}}

But this is fine:

{{#docs-demo as |demo|}}
  {{#demo.example name="example.hbs"}}
    <hr class="input-class" />
  {{/demo.example}}

  {{demo.snippet "example.hbs"}}
{{/docs-demo}}

[bitwolfe]

Also PR #413 does not fix the above issue.

[RobbieTheWagner]

@samselikoff according to @bitwolfe that PR did not fix the issue?

[bitwolfe]

This issue still exists with 0.10.0

[bitwolfe]

I found a workaround for my issue at least, sharing here incase someone else runs into this. Adding a blank line at the beginning of the example block seems to fix my issue. So going with the same example as I used before:

This doesn't work:

{{#docs-demo as |demo|}}
  {{#demo.example name="example.hbs"}}
    <hr class="inputClass" />
  {{/demo.example}}

  {{demo.snippet "example.hbs"}}
{{/docs-demo}}

But this does!

{{#docs-demo as |demo|}}
  {{#demo.example name="example.hbs"}}

    <hr class="inputClass" />
  {{/demo.example}}

  {{demo.snippet "example.hbs"}}
{{/docs-demo}}

Super strange.

[RobbieTheWagner]

@bitwolfe we're using DocsDemo for ember-flatpickr and it seems to work fine for our use case. https://github.com/shipshapecode/ember-flatpickr/blob/master/tests/dummy/app/templates/docs/components/ember-flatpickr.md

I'm curious what the difference is or if it's just that we're using angle brackets? Would love to narrow down what doesn't work.

[bitwolfe]

@rwwagner90 I've tested with angle brackets as well, that doesn't seem to matter.

The below also fails with the same error:

Closing tag p(on line 5) did not match last open tagDocsDemo (on line 2).

# Demo

<DocsDemo as |demo|>
  <demo.example @name="example.hbs">
    <hr class="fooBar"/>
  </demo.example>

  <demo.snippet @name="example.hbs"/>
</DocsDemo>

Again, adding a blank line before the hr tag magically makes it work.