Fix examples bug on writing-helpers.md#112
Merged
sivakumar-kailasam merged 5 commits intoember-learn:masterfrom Jul 23, 2018
Merged
Fix examples bug on writing-helpers.md#112sivakumar-kailasam merged 5 commits intoember-learn:masterfrom
sivakumar-kailasam merged 5 commits intoember-learn:masterfrom
Conversation
Member
|
If it isn't too much trouble can you make the changes in 3.3, 3.1 & 3.0 docs as well? |
Contributor
Author
|
Sure, I'll need to do a proper fork then. I'll try and do it over the week-end. |
Member
|
FYI, a branch is already created on your fork for this PR when you edited it via the UI, so you could edit the other files there from the github ui as well. No hurry though 😄 |
Contributor
Author
|
Thanks for the tip 👍 I updated the PR to include 3.3, 3.1 & 3.0 docs as well. |
sivakumar-kailasam
approved these changes
Jul 23, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.