Update docs to use prefixed this. in templates#149
Update docs to use prefixed this. in templates#149chadhietala wants to merge 1 commit intoember-learn:masterfrom
this. in templates#149Conversation
|
I have questions about whether changes like these should merge now or be part of an "ember editions" push. @ember-learn/learning-team and @chadhietala, what are your thoughts? |
|
Hi! This PR was still open as of creating the 3.5 release. This means before this PR to be merged, any changes requested should be made, and then the same additions should be applied to the upcoming 3.5 version files. They will be available later this week. Sorry about the extra step! |
|
I'm not sure as these changes are related to an RFC that pre-dates Editions. In the RFC I outlined the transition path. The only parts that aren't done are updating the docs and moving forward on making this a default template lint sort of requires the docs to be updated. I would like to hear what @tomdale has to say since there have been talks about grouping behavior like this as part of Octane edition. |
|
Unless someone has a specific objection to merging this, let's do it at the end of this week. I get the sense that nobody actually thinks this needs to be deferred, we all just think that other people think it needs to be deferred. |
|
To dos:
|
--- Commit: ember-learn/super-rentals-tutorial@a92fddd Script: https://github.com/ember-learn/super-rentals-tutorial/blob/a92fdddfa44a3d12a405e0c4bbe7974bf9e4251f/.github/workflows/build.yml Logs: https://github.com/ember-learn/super-rentals-tutorial/commit/a92fdddfa44a3d12a405e0c4bbe7974bf9e4251f/checks
3 participants
This likely needs to be read through end-to-end to ensure we are not missing anything. This is part of the migration plan for RFC#308