[RFC-774] Remove documentation for implicit route model#1907
Conversation
|
Thank you! I like the prose you added. However, the soon to be deprecated behavior is such a big gotcha, so I think it may still merit a small, concise warning about the behavior when someone does nothing with the model hook. I have a hypothesis that this behavior is one of Ember’s main stumbling blocks for beginners. For best developer experience, I think we would want to keep the warning until support is dropped in a major. What do you think about that? Someone would see a deprecation warning to help guide them too, but my experience is that those accumulate, and devs may ignore them due to alert fatigue. Regardless, I don’t think we need to wait for the deprecation to land in order to ship this. The guides should represent the general way we want to encourage people to write ember apps, and we don’t need to cover all approaches in the guides. |
33504de to
985faf3
Compare
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jenweber
left a comment
There was a problem hiding this comment.
Left you a small wording change. We can emphasize our product priorities of nicer dev experience.
Co-authored-by: Jen Weber <j@jenweber.me>
RFC-774
I believe it is safe to merge this now even before the deprecation has been merged, but I'm open to alternative ways to handle this.
emberjs/ember.js#20376