WIP do not merge - Beginning angle bracket notation conversion#292
Closed
cah-danmonroe wants to merge 6 commits intoember-learn:masterfrom
Closed
WIP do not merge - Beginning angle bracket notation conversion#292cah-danmonroe wants to merge 6 commits intoember-learn:masterfrom
cah-danmonroe wants to merge 6 commits intoember-learn:masterfrom
Conversation
Array helper merged
This was referenced Dec 3, 2018
Member
|
Closing this in favour of #357 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - Do not merge.
I have updated the 3.6 version docs with angle bracket notation. I didn't see that there were separate issues for each section until I was done with all of it and started to make this PR - sorry.
I have a couple comments/questions:
We should probably re-write component naming description in
defining-a-component.mdShould we talk about why a helper is different and can't use < notation?
Is the <MyComponent change for array helpers correct in
built-in-helpers.md?