You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ack "rsvp" guides/release/ still shows a few places where RSVP is referenced.
guides/release/configuring-ember/debugging.md
123:import RSVP from 'rsvp';
guides/release/contributing/repositories.md
58:* **rsvp.js** - Implementation of the of Promises/A+ spec used by Ember.
59:* [https://github.com/tildeio/rsvp.js](https://github.com/tildeio/rsvp.js)
guides/release/routing/asynchronous-routing.md
57:take a look at the readme for [RSVP](https://github.com/tildeio/rsvp.js),
guides/release/routing/specifying-a-routes-model.md
125:[RSVP.hash](https://www.emberjs.com/api/ember/release/classes/rsvp/methods/hash?anchor=hash).
131:import RSVP from 'rsvp';
214:import RSVP from 'rsvp';
In this Discuss post, there are two examples on how the RSVP.hash method could be refactored.
@ppcano I purposefully left those references because they seemed to make sense in context.
In the debugging section, it's talking about debugging RSVP promises.
Since RSVP has been recommended for a while and is still provided by default, it seems better to leave the prose in place.
The repositories reference was left for mostly the same reason. It is part of the default stack.
Another reasons for leaving it alone is that there is an (RFC for improving the Contributing guides)[https://github.com/emberjs/rfcs/pull/446].
I kept RSVP.hash because I think it is cleaner and less error prone than the refactorings.
I've removed the mention in the async routing guide!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #237.
@ppcano can you 👀?