Update docs for the built-in components in routing/query-params.md#698
Merged
locks merged 2 commits intoember-learn:octanefrom Mar 30, 2019
Merged
Conversation
Contributor
Author
|
I have a hard time figuring out why the build failed, any pointer? |
16 tasks
chancancode
approved these changes
Mar 29, 2019
Contributor
chancancode
left a comment
chancancode
left a comment
There was a problem hiding this comment.
Some minor copy-edits but otherwise LGTM
| `setupController`, etc.); it will only update the URL. | ||
|
|
||
| ### link-to Helper | ||
| ### LinkTo component |
Contributor
There was a problem hiding this comment.
I think we probably want <LinkTo /> here to be consistent, but I'm not 100% sure 🤔
| matching the leaf-most controller with the supplied property name. | ||
|
|
||
| The `link-to` helper takes into account query parameters when determining | ||
| The `<LinkTo>` component takes into account query parameters when determining |
Contributor
There was a problem hiding this comment.
<LinkTo />, to be consistent (I'm actually not a 100% sure if we want to consistently do <LinkTo> or consistently do <LinkTo />; but so far we have been doing the latter and I think it's better to keep it consistent and fix everything in one go later if we want to)
chancancode
approved these changes
Mar 29, 2019
locks
approved these changes
Mar 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #692