Angle-bracket-ize tutorial/autocomplete-component.md#702
Merged
locks merged 4 commits intoember-learn:octanefrom Apr 2, 2019
zachgarwood:angle-bracket-ize--tutorial--autocomplete-component
Merged
Angle-bracket-ize tutorial/autocomplete-component.md#702locks merged 4 commits intoember-learn:octanefrom zachgarwood:angle-bracket-ize--tutorial--autocomplete-component
locks merged 4 commits intoember-learn:octanefrom
zachgarwood:angle-bracket-ize--tutorial--autocomplete-component
Conversation
16 tasks
chancancode
reviewed
Mar 29, 2019
chancancode
reviewed
Mar 29, 2019
chancancode
approved these changes
Mar 29, 2019
pzuraq
approved these changes
Mar 29, 2019
Also, I reformatted the paragraphs in question to be <80 characters long. (#692)
Contributor
Author
|
I followed @chancancode 's suggestions and did some minor reformatting. |
chancancode
reviewed
Mar 29, 2019
locks
requested changes
Mar 30, 2019
Contributor
Author
|
I implemented @chancancode / @locks 's suggested change. |
locks
approved these changes
Apr 2, 2019
Contributor
|
Thanks for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the built-in components to use angle bracket syntax. See #692