Class private methods are not enabled.

[NullVoxPopuli]

I just upgraded tracked-built-ins in an addon and am getting this error:

Build Error (broccoli-persistent-filter:Babel > [Babel: tracked-built-ins]) in tracked-built-ins/-private/object.js

ember-statechart-component/tracked-built-ins/-private/object.js: Class private methods are not enabled.
  65 |
  66 |   // @private
> 67 |   #readStorageFor(key) {
     |   ^
  68 |     let storage = this.#storages.get(key);
  69 |
  70 |     if (storage === undefined) {

but, what's weird, is that I've worked on tracked-built-ins with private methods... and this wasn't an issue at all.

My ember-cli-babel appears up to date:

❯ npm ls ember-cli-babel
├─┬ @ember/test-helpers@2.6.0
│ ├─┬ @ember/test-waiters@3.0.0
│ │ └── ember-cli-babel@7.26.6 deduped
│ ├── ember-cli-babel@7.26.6 deduped
│ └─┬ ember-destroyable-polyfill@2.0.3
│   └── ember-cli-babel@7.26.6 deduped
├─┬ @glimmer/component@1.0.4
│ └── ember-cli-babel@7.26.6 deduped
├─┬ ember-auto-import@1.12.0
│ ├─┬ @embroider/core@0.33.0
│ │ └─┬ @embroider/macros@0.33.0
│ │   └── ember-cli-babel@7.26.6 deduped
│ └── ember-cli-babel@7.26.6 deduped
├── ember-cli-babel@7.26.6
├─┬ ember-cli-typescript-blueprints@3.0.0
│ └── ember-cli-babel@7.26.6 deduped
├─┬ ember-could-get-used-to-this@1.0.1
│ └── ember-cli-babel@7.26.6 deduped
├─┬ ember-load-initializers@2.1.2
│ └── ember-cli-babel@7.26.6 deduped
├─┬ ember-maybe-import-regenerator@0.1.6
│ └── ember-cli-babel@6.18.0
├─┬ ember-page-title@6.2.2
│ └── ember-cli-babel@7.26.6 deduped
├─┬ ember-qunit@5.1.5
│ ├── ember-cli-babel@7.26.6 deduped
│ └─┬ ember-cli-test-loader@3.0.0
│   └── ember-cli-babel@7.26.6 deduped
├─┬ ember-resolver@8.0.3
│ └── ember-cli-babel@7.26.6 deduped
├─┬ ember-source@3.26.2
│ └── ember-cli-babel@7.26.6 deduped
├─┬ qunit-dom@1.6.0
│ └── ember-cli-babel@7.26.6 deduped
├─┬ tracked-built-ins@2.0.0
│ ├── ember-cli-babel@7.26.6 deduped
│ └─┬ ember-tracked-storage-polyfill@1.0.0
│   └── ember-cli-babel@7.26.6 deduped
└─┬ tracked-maps-and-sets@3.0.2
  └── ember-cli-babel@7.26.6 deduped


ember-statechart-component on  upgrade-debs [$!] 

  origin  git@github.com:NullVoxPopuli/ember-statechart-component.git 

❯ latestPkgVer ember-cli-babel
Current:
"7.26.6"

Tags:
{
  "latest": "7.26.6",
  "alpha": "7.0.0-alpha.2",
  "beta": "7.24.0-beta.2",
  "5.x": "5.2.8",
  "old": "6.17.2"
}

Most Recent:
"7.26.6"

and browserslist seems to be up to date as well.

❯ npx browserslist --update-db
Latest version:     1.0.30001279
Installed version:  1.0.30001279
caniuse-lite is up to date
caniuse-lite has been successfully updated

No target browser changes

[nightire]

I've seen it recently after I upgraded tracked-built-ins to v2. I have no idea what causes this error, so I raised an issue here: tracked-tools/tracked-built-ins#204

[NullVoxPopuli]

that's the library where am seeing this, too.

It's not tracked-built-ins' fault tho. We should be able to use private properties and methods in our apps -- if we do, we get the same error.

[NullVoxPopuli]

oh! I just tested this, that's not true!!! private methods work just fine in the host app.

ok, so this bug with ember-cli-babel is that addons are not appropriately inheriting the browserlist or targets? 🤔 maybe?

[SergeAstapov]

Another option, smith with TS compilation as add-on source is .ts

EDIT: I may be wrong as there are .js files

[NullVoxPopuli]

tracked-built-ins is a V1 addon, so TS compilation happens as a result of the app telling the addon to compile... which.. is handled by the host's ember-cli-babel 🤔 I think ember-cli-babel has a misconfiguration for addons 🤔

[rwjblue]

Is there a minimal reproduction for this? Can someone give me a repo to clone (with either a lockfile that demonstrates the issue, or checked in node_modules)?

[NullVoxPopuli]

on it

[chriskrycho]

@NullVoxPopuli I'm already pushing a repro repo.

[NullVoxPopuli]

Here is my repro: NullVoxPopuli/repro-for-emberjs-19790#2
(branch: ember-cli-babel-issues-419)
all you need to do is yarn && yarn build

[chriskrycho]

Lulz. Here's mine. Same.

[NullVoxPopuli]

Lulz. Here's mine. Same.

🙌

[chriskrycho]

Additional info to make things extra complicated: we’re now consuming latest v. of tracked-built-ins in the big app at LinkedIn, with no issues. And our build is not doing anything to configure private class fields (as you would expect given the status of that proposal!). Notably, both our app and the repro apps are all resolving ember-cli-babel 7.26.6, so it's unlikely it's ember-cli-babel itself. I will continue reporting as I have time.

[rwjblue]

Debugged this with @chriskrycho a bit. The main issue (we believe) is that ember-cli-babel is always adding @babel/plugin-proposal-class-properties (which we added originally for decorators support):

https://github.com/babel/ember-cli-babel/blob/4c3b9091d7c711ecb804a52226409b409a702d82/lib/babel-options-util.js#L345-L359

Path forward in this repo is to change that guard above to only add the class-properties plugin when it is needed (possibly by using isPluginRequired).

Unfortunately, we also need to land some fixes to ember-data LTS versions. Specifically, the version of rollup they use in their internal build infrastructure does not support class fields, so when ember-cli-babel stops automatically adding that plugin ember-data's build fails like:

- broccoliBuilderErrorStack: Error: Unexpected token
    at error (/Users/chris/dev/test/yoooooo/node_modules/rollup/dist/shared/node-entry.js:5400:30)
    at Module.error (/Users/chris/dev/test/yoooooo/node_modules/rollup/dist/shared/node-entry.js:9824:16)
    at tryParse (/Users/chris/dev/test/yoooooo/node_modules/rollup/dist/shared/node-entry.js:9717:23)

At the moment that is using rollup@^1.12.0, via these packages:

https://github.com/emberjs/data/blob/362ae1af977b9a4ca328cc0aafc45b87e6041b91/packages/private-build-infra/package.json#L27

https://github.com/chadhietala/broccoli-rollup/blob/c45027c53e0b72c5f06158e3efed67cc63f4ef8f/package.json#L53

tldr; we need to bump @ember-data/-private-build-infra to use broccoli-rollup@5 (which allows us to upgrade to latest rollup, which should support the syntax we need).