reroll lock file and update test#524
Merged
mansona merged 3 commits intoemberjs:masterfrom Feb 1, 2026
Merged
Conversation
kategengler
reviewed
Feb 1, 2026
| // shut down any workerpool that is running at this point | ||
| let babelCoreVersion = ParallelApi.getBabelVersion(); | ||
| let workerPoolId = 'v2/broccoli-babel-transpiler/workerpool/babel-core-' + babelCoreVersion; | ||
| let workerPoolId = 'v2/broccoli-babel-transpiler/async-workerpool/babel-core-' + babelCoreVersion; |
Member
There was a problem hiding this comment.
Oops. That change was made here ember-cli/broccoli-babel-transpiler#241
~~Do we need to backport this? cc @ef4 ~~ nvm this is tests
Member
Author
There was a problem hiding this comment.
yea I had the same slight panic when I saw the change but came to the same conclusion that it's something low-level a test helper is doing and it's reasonable to not worry about it 👍
kategengler
approved these changes
Feb 1, 2026
void-mAlex
approved these changes
Feb 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can see that the floating dependencies test on #523 failed and the #522 PR is failing for the same reason
So this PR floats the lockfile and updatest the test 👍
Edit: it looks like the name of the worker changed and that was causing tests to hang (the testing tool that was looking for the worker to force shutdown wasn't able to find it). This PR updates that too 👍