Skip to content

Add owner to the list of properties of an object#2680

Merged
mansona merged 6 commits intoemberjs:mainfrom
mainmatter:pichfl/get-owner
Aug 18, 2025
Merged

Add owner to the list of properties of an object#2680
mansona merged 6 commits intoemberjs:mainfrom
mainmatter:pichfl/get-owner

Conversation

@pichfl
Copy link
Copy Markdown
Contributor

@pichfl pichfl commented Aug 12, 2025

Description

Provides the owner of an object as a separate field within the object inspector if present.

Closes #2630

Screenshots

image

pichfl and others added 2 commits August 12, 2025 20:10
This is a first iteration that grabs and sets $E to the global owner.

Re emberjs#2630
@mansona mansona marked this pull request as draft August 13, 2025 16:36
@pichfl pichfl marked this pull request as ready for review August 14, 2025 12:35
@pichfl pichfl requested a review from mansona August 14, 2025 12:36
mansona and others added 2 commits August 14, 2025 16:27
A symbol doesn't work because it needs to be copied across boundaries, so using `__owner__` is the next best thing.
Copy link
Copy Markdown
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there 🎉

Copy link
Copy Markdown
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 💪

@mansona mansona merged commit 6a2cffc into emberjs:main Aug 18, 2025
19 checks passed
@pichfl pichfl deleted the pichfl/get-owner branch August 18, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A shortcut for "get Owner"

2 participants