[WIP] New API Iteration

[rwjblue]

This is an effort to reduce ember-qunit's surface area, and leave the "testing framework" work to QUnit.

It is heavily inspired by the work that @Turbo87 did for ember-mocha (checkout their API here).

Sample integration test with the new API:

import { module, test } from 'qunit';
import { buildIntegrationOptions } from 'ember-qunit';

module('component:x-foo', buildIntegrationOptions({
  beforeEach() {
    // special setup stuff
  }
}));

test('renders', function(assert) {
  assert.expect(1);

  this.render(hbs`{{pretty-color name="red"}}`);

  assert.equal(this.$('.color-name').text(), 'red');
});

---

I've also added work to enable an even nicer API (IMHO of course) with nested modules, but that effort is blocked by qunitjs/qunit#977.

The nested modules API would look like:

import { module, test } from 'qunit';
import { setupIntegrationTest } from 'ember-qunit';

module('component:x-foo', function(hooks) {
  setupIntegrationTest(hooks);

  test('renders', function(assert) {
    setupRegistry();
    assert.expect(1);

    this.render(hbs`{{pretty-color name="red"}}`);

    assert.equal(this.$('.color-name').text(), 'red');
  });
});

[Turbo87]

[rwjblue]

Need to add options.after to clear module so that it does not get retained.

[Turbo87]

@rwjblue rebased and added the after block

[rwjblue]

Thanks Tobias!

[Turbo87]

@rwjblue looking at the examples above, do you want to use the test module name as the descriptor for the thing to be tested? that seems a little error prone to me and will not allow people to specify a more readable name explicitly like in the new Mocha API.

[trentmwillis]

I agree with @Turbo87. It should be like:

module('Some description', function(hooks) {
  setupIntegrationTest('component:foo-bar', hooks);
});

// or

module('Some description', buildIntegrationOptions('component:foo-bar', {}));

[rwjblue]

@trentmwillis - The argument that you pass to setupIntegrationTest there is not needed or used for anything, only the current "unit tests" use that argument (and I don't intend to add back that monstrosity)...

[trentmwillis]

Well for the ones that need it, I was just modifying the existing example. I assume it is still needed for unit tests.

[jbescoyez]

@rwjblue It looks like this PR will fix #208 and allow nested modules. What's the current status of this PR. How can I help?

[rwjblue]

I spent a ton of time this weekend making progress on this. The first major step was to migrate ember-test-helper and ember-qunit to be "real" addons (to allow faster iteration here).

• Migrate to an addon. ember-test-helpers#213
• Make into an addon. #282
• Remove functionality to defer to ember-qunit API. ember-cli/ember-cli-qunit#191

The next step is cleaning up some testing infrastructure in ember-test-helpers (to ensure that things work properly without jQuery) before starting in on the new API. You can follow that effort in emberjs/ember-test-helpers#215.

After that lands (and we release 0.7.0 of ember-test-helpers), I will begin working on the "real" implementation of emberjs/rfcs#230 (which replaced this spike).

[rwjblue]

The best way to help at the moment is likely to help us in testing ember-cli-qunit@4.1.0-beta.2 (feel free to join us in #dev-testing in the community slack). Once ember-cli-qunit@4.1.0-beta.2 is hammered on by a few different folks/apps/etc we can move it out of beta allowing further progress on the new API surface.

[rwjblue]

Closed by #286.