(Real™ package™)™

[NullVoxPopuli]

Replaces: #345

BREAKING:

• requires ember-auto-import or embroider
• drop support for ember-source < 3.28
• drop support for ember-cli < 3.28

Maybe breaking:

• Drop support for TS 4.9
  • We haven't declared a rolling support policy

Overall output:

❯ cat dist/index.js | wc -l
     142

❯ cat declarations/index.d.ts | wc -l
     160

A note on the diff:

---

a type=module packages is more of a real package than a v2 addon (currently) because v2 addons are often CJS masquerading as ESM. When a package.json does not have type=module specified, it's assumed that the .js extension means "Common JS" / require. This isn't great if we want to be better integrated with broader ecosystem tooling. So, since @ember/string does not depend on any ember APIs, it's actually a great candidate for using real ESM, ahead of auto-import/embroider releasing fixes for ESM "ember-addon" packages. (An ember-addon is a package with ember-addon in its keywords list)

Where'd the test-app go?

I deleted it. This work is under the assumption that, because we don't use anything from ember, and because vitest knows nothing about ember, some basic unit tests ensure that the package works, and would be compatible with all versions of ember that have ember-auto-import or are using embroider.

[mkszepp]

Node is here v20, but in ci scripts v18... maybe its better to hold sync

[NullVoxPopuli]

good point -- node is actually irrelevant now, so I can clean up CI a bit, let it be defaults.