Possible Regression: Query params alias behavior changed?

[wagenet]

In 1.13.8 I had the following code:

// controller.js
  queryParams: {
    displayMode: "mode"
  }

// route.js
  queryParams: {
    mode: {
      replace: true
    }
  }

However, this started giving an error in 2.0:

You're not allowed to have more than one controller property map to the same query param key, but both app:displayMode and app:mode map to mode. You can fix this by mapping one of the controller properties to a different query param key via the as config option, e.g. displayMode: { as: 'other-displayMode' }

Changing the route to the following solved the issue.

  queryParams: {
    displayMode: {
      replace: true
    }
  }

[rwjblue]

Can you provide a reproduction ember-twiddle / JSBin ?

[SaladFork]

Reproduction:

• 2.0.0 JSBin: Change input to cause error
• 1.13.8 JSBin: Identical code but older Ember version, no error

[KTKate]

Not sure if this is the same or something different but here is a Twiddle showing the queryParams alias doesn't work at all in 1.13.8. Maybe that's why there was no error in 1.13.8.

If you have:

 queryParams: ['color', {perPage: 'per_page'}, {firstName: 'first_name'}],

Then per_page and first_name is never used.

http://ember-twiddle.com/5e1e9fe67b616837bf97

[lolmaus]

Possibly related: #11592.

[pixelhandler]

another related/duplicate issue: #11977

[v3ss0n]

same problem. Still in 2.6
SO it is a bug?

[raytiley]

I think #13273 will address this /CC @rwjblue

[rwjblue]

Thanks @raytiley. I'm going to close this for now, but I would love to land a new query params test to ensure we do not regress here in the future. Feel free to ping me if you would like help on how that might look...