LinkComponent cannot be yielded as a contextual component

[phcoliveira]

First of all, I did look at StackOverflow before creating this issue. As a matter of fact, I could not find anything about this, and I am pretty sure that I am not the only one who tried this.

{{!-- components/a-component/template.hbs --}}
{{yield (hash
  contextual-link=(component "link-to" class="a-component__contextual-link")
}}
{{!-- END --}}

{{!-- somewhere else --}}
{{#a-component as |component|}}
  {{#component.contextual-link "some.route"}}
    Unfortunately, this does not work.
  {{/component.contextual-link}}
{{/a-component}}
{{!-- END --}}

When used like that, LinkComponent will complain the it needs at least one parameter. When one bogus parameter is supplied in the template of a-component, such as "application", it won't be replaced by the time the contextual-link is invoked.

Am I missing something?

[pixelhandler]

@phcoliveira I see a missing closing parenthesis in the a-component.

See this twiddle, this seems to work: https://ember-twiddle.com/9a253ac0acae6fc9d88c7dd6e0ce0e10?openFiles=templates.components.my-link.hbs%2C

[phcoliveira]

I apologize for not describing the problem as I am exactly seeing. What I am trying to do is something different, but possible when not used as contextual component.

Ember.Component.extend({
  linkParams: Ember.computed('route', 'model', function() {
    return [this.get('route'), this.get('model.id')];
  })
});

{{#a-component as |component|}}
  {{#component.contextual-link params=linkParams}}
    Does not work here
  {{/component.contextual-link}}
{{/a-component}}


{{#link-to params=linkParams}}
  But it works here
{{/link-to}}

[pixelhandler]

@phcoliveira can you make an ember-twiddle example that reproduces your issue?

[Serabe]

Investigating.

[Serabe]

Reproduction.

This only happens in 2.9 since this behaviour is fixed in Glimmer 2 (reproduction). This used to work in 2.7 but broke in 2.8 (reproduction in 2.7) so I would consider this a regression. I'll try to land a fix this morning though if I don't get it right, I won't be able to fix it until Ember Fest.

[Serabe]

Thanks to @locks to noticing that reproduction in 2.7 does not transition but renders, but in 2.6 does render and transitions (reproduction).

[Serabe]

Summary

This bug was introduced partially in 2.7, while fixing another issue with rest positional params. In 2.7 the component would render, but would received an empty params.

In 2.8, it stopped rendering given that an assertion was added to check that link-to receives at least one parameter.

I submitted a PR for fixing this in 2.9 and I am now checking for LTS. Since this seems to be a regression, I have some hope in getting it there.

Thank you all for this report!