[Bug] Incorrect "import htmlSafe from '@ember/string'" deprecation warning when importing from '@ember/template'

[urbany]

Hi everyone, after upgrating to latest stable ember-source@3.25.1 I'm getting:

DEPRECATION: Importing htmlSafe from '@ember/string' is deprecated. Please import htmlSafe from '@ember/template' instead. [deprecation id: ember-string.htmlsafe-ishtmlsafe]

the thing is my helper is importing correctly:
import { htmlSafe } from '@ember/template';
but when i check the compiled version on the browser it is compiling to:
Ember.String.htmlSafe

which is triggering the deprecation warning.

@locks suggested on Discord it might be related to https://github.com/ember-cli/ember-rfc176-data needing an update

[locks]

We seem to have missed some necessary work for the correct implementation of the deprecation. I will be using this comment to track the necessary work.

Tracking

• Nerf deprecation in a patch
• export non-deprecated htmlSafe and isHTMLSafe from a private namespace in the Ember global, e.g. Ember._Template
• figure out how to have per-Ember version mappings in ember-rfc176-data
• incorporate change in babel-plugin-ember-modules-api-polyfill and ember-cli-babel
• re-introduce deprecations for htmlSafe and isHTMLSafe
  • make sure that String.prototype.htmlSafe is deprecated

[jamescdavis]

As the person who did the original deprecation PR, I apologize for the inconvenience!

[nadnoslen]

Not that big of a deal @jamescdavis 😉

[DLiblik]

Not that big of a deal @jamescdavis 😉

Tell that to our CI server test logger LOL... just found this out today when our log files went super-nova recently

All good!