[WIP] RFC12: Getter CP readOnly by default#10778
Closed
cibernox wants to merge 10 commits intoemberjs:masterfrom
Closed
[WIP] RFC12: Getter CP readOnly by default#10778cibernox wants to merge 10 commits intoemberjs:masterfrom
cibernox wants to merge 10 commits intoemberjs:masterfrom
Conversation
* In getter-only CP's because they are already readOnly by default * In properties with a setter because if if there is a setter they can't be readOnly (obviously)
Member
|
Since this didn't make it into 2.0.0, is there a path forward here? It is unclear to me... |
Contributor
Author
|
Not as it is right now. I'll be happy to revisit this (and other CP-related open questions like the one exposed in RFC 79), but the code in this PR can't be merged anymore. I'm going to close this, and if the time comes I can code this from scratch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early WIP of RFC 12
There is quite a lot of failing tests because they relay on overriding computed properties for mocking. Not sure what is the best approach on this.
P.e, is quite common to stub the
controllersproperty of controllers that specify aneeds, but outside testing seems a bad to allow that property to be overridable