[BUGFIX beta] Fix assertion to make sure doesn't affect old CP syntax#10968
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Apr 28, 2015
Merged
[BUGFIX beta] Fix assertion to make sure doesn't affect old CP syntax#10968rwjblue merged 1 commit intoemberjs:masterfrom
rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
rwjblue
added a commit
that referenced
this pull request
Apr 28, 2015
[BUGFIX beta] Fix assertion to make sure doesn't affect old CP syntax
Member
|
Looks good, my only suggestion is to change the message to not use the phrase "new syntax", since this will be very confusing for new users in a few months who only know of the new syntax. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10761 I introduced an assertion was raised on
readOnlywhen the function has a setter.While this is a reasonable check, it is a breaking change for people using the old CP syntax.
This assertion is only thrown if the getter and setter functions are different, so won't affect existing users.
/cc @tomdale