Fix SC.Button form submission issues by adding a configurable type property

[ebryn]

No description provided.

[wycats]

Can you include test cases?

[ebryn]

How do those look?

[mgood]

Ah, I'd been trying something similar and also noticed that my renderBuffer wasn't being called, so I ended up overriding applyAttributesToBuffer like this:

applyAttributesToBuffer: function(buffer) {
this._super(buffer);
var buttonType = get(this, 'buttonType');
if (buttonType) {
buffer.attr('type', buttonType);
}
},

WDYT?

[ebryn]

I think that the Handlebars view helper should be calling into the view it's rendering to use it's renderBuffer rather than ignoring it and creating one in the view helper.

[tomdale]

I'm not super comfortable with overriding the render buffer to add attributes. Maybe we should consider switching SC.Button to use a defaultTemplate, like SC.Checkbox does?

[trek]

I had to take a similar approach for wrapping native option and needing to set the value attribute: https://gist.github.com/1027727

Using the collection helper so I could use bindAttr inserted additional markup into the option tags that the browser wouldn't happily parse.

With native form controls there's occasionally a need to set the tagName and be able to supply certain attributes on the DOM representation. I also couldn't find another way to accomplish this currently except for overriding applyAttributesToBuffer()

Maybe have an array of properties that, when set on the view, are passed to the element? Or having a similar approach to item* property names

SC.Button = SC.View.extend({
  tagAttributes: ['type'],
  ...
})

{{#view SC.Button type='submit'}}
  Click Me
{{/view}}

or


SC.Button = SC.View.extend({
  ...
})

{{#view SC.Button elemenType='submit'}}
  Click Me
{{/view}}

[ebryn]

tomdale: The problem with using a defaultTemplate is that SC.Button uses the button tag which has it's value rendered inside of the tag, rather than as an attribute. AFAIK there isn't a way to render the content provided within the #view block in a defaultTemplate.

Greg blogged about creating a TextArea view, which has the same problem. Would you rather it be implemented like he did? http://blog.sproutcore.com/dispatches-from-the-edge-handlebars-without-spans/#more-1332

[ebryn]

Actually, the TextArea is different. It doesn't use a #view block helper, so that makes it easier.

[tomdale]

I'll add attribute/attribute binding support to make this work.