[DOC Release] Mark Controller.transitionTo as public#11580
Closed
joeruello wants to merge 1 commit intoemberjs:masterfrom
joeruello:transition-to-controller
Closed
[DOC Release] Mark Controller.transitionTo as public#11580joeruello wants to merge 1 commit intoemberjs:masterfrom joeruello:transition-to-controller
joeruello wants to merge 1 commit intoemberjs:masterfrom
joeruello:transition-to-controller
Conversation
Member
|
This was deprecated in 1.x so it seems OK to make private for 2.0.0. I'm gonna close this, but thank you for taking the time to review and submit! |
Contributor
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11362 Enforced marking docs explicitly to end confusion on what is Public/Private API. I'm having a look through and flagging code I think may have been incorrectly marked.
This function is deprecated, but I thought I was technically correct to remark it back to public for prosperity's sake.