[BUGFIX release] Fix cacheValuePrefix Error#12037
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Aug 10, 2015
Merged
Conversation
Member
|
Looks good, can you prefix the commit and PR description with [BUGFIX release]? |
Contributor
|
awesome |
Fixed an issue where cacheValuePrefix would incorrectly check "valA in valB" where valB would be null Resolves Issue emberjs#11857
Contributor
Author
|
Didn't notice the failing tests.. Fixing that now |
rwjblue
added a commit
that referenced
this pull request
Aug 10, 2015
[BUGFIX release] Fix cacheValuePrefix Error
Member
|
Thank you! |
|
Not sure if it is related but starting from 1.13.8 I experience some problems with query parameters. I have following scenario: But before, just used to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where cacheValuePrefix would incorrectly check "valA in valB" where valB would be null
Fixes #11857