[BUGFIX canary] Honor customEvents opting out of event listeners.#12059
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Aug 13, 2015
Merged
[BUGFIX canary] Honor customEvents opting out of event listeners.#12059rwjblue merged 1 commit intoemberjs:masterfrom
customEvents opting out of event listeners.#12059rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
Setting `customEvents` to a hash in an application is a way to add new
listeners that the `EventDispatcher` knows about.
Often, users see this and decide that they want to disable a given event
(for example `mouseenter` and `mouseleave` events) and think they can do
something like:
```javascript
var App = Ember.Application.create({
customEvents: {
mouseenter: null,
mouseleave: null
}
});
```
Unfortunately, that just makes the `EventDispatcher` call a method named
`null` on the view/component instances (LOL).
This fixes that bug by allowing a `null` value to disable the event
listener.
rwjblue
force-pushed
the
opt-out-events
branch
from
6bd65a0 to
acbb0b2
Compare
rwjblue
added a commit
that referenced
this pull request
Aug 13, 2015
[BUGFIX canary] Honor `customEvents` opting out of event listeners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
customEventsto a hash in an application is a way to add new listeners that theEventDispatcherknows about.Often, users see this and decide that they want to disable a given event (for example
mouseenterandmouseleaveevents) and think they can do something like:Unfortunately, that just makes the
EventDispatchercall a method namednullon the view/component instances (LOL).This fixes that bug by allowing a
nullvalue to disable the event listener.Fixes #11540.