[DOC] Add router.js to yuidoc.json

[Gaurav0]

This is for issue #12142

[rwjblue]

Please update the locked SHA in bower.json to use 04b27c911995902b022966f4d29d8686ba7d847c (which includes your changes from emberjs/router.js#169).

[rwjblue]

For others, the compare view: emberjs/router.js@ed45bc5...04b27c9

[Gaurav0]

@rwjblue Updated. Don't know what is wrong with sauce test.

[stefanpenner]

sgtm. Do the output docs feel/look reasonable ?

Some future work to make it easy to preview them in these cases would be rad.

[rwjblue]

@stefanpenner - Yes, this is exactly my concern.

I think we need to actually boot up the website and see what it looks like with these changes (there are docs here that describe how to preview local changes). My hunch is that there are other objects (like Transition itself) that are incorrectly documented, but this is still likely a net positive assuming we can confirm that it all works well.

[Gaurav0]

Some screenshots to satisfy your preview concerns. I am in no way qualified to determine if they "feel/look reasonable".

[ghost]

👍

[Gaurav0]

@rwjblue I excluded all of router.js from the yuidoc.json except for transition.js as discussed in #documentation on slack. Does this work for you?

[acorncom]

@Gaurav0 there's a failing test here, not sure if it's related to what you're doing or not ...

[Gaurav0]

@acorncom I doubt it, since I just edited yuidoc.json But I can't rerun it.

[Gaurav0]

@rwjblue Please review.

[wycats]

I see no reason not to merge this.

[Gaurav0]

@wycats Thank you.