Added a failing test for #12212. #12215
Closed
workmanw wants to merge 1 commit intoemberjs:masterfrom
Batterii:computed-sort-failing-test
Closed
Added a failing test for #12212. #12215workmanw wants to merge 1 commit intoemberjs:masterfrom Batterii:computed-sort-failing-test
workmanw wants to merge 1 commit intoemberjs:masterfrom
Batterii:computed-sort-failing-test
Conversation
…ted.sort used on class with multiple instances.
Member
|
will look shortly |
mmun
added a commit
to mmun/ember.js
that referenced
this pull request
Feb 21, 2016
Resolves a regression in `Ember.computed.sort` that has existed since 2.0.0. The regression occurred when there were multiple instances of a class using `Ember.computed.sort` and caused the sorted value to stop updating. Closes emberjs#12212. Closes emberjs#12215. Closes emberjs#12221. Closes emberjs#12516.
rwjblue
pushed a commit
that referenced
this pull request
Feb 21, 2016
Resolves a regression in `Ember.computed.sort` that has existed since 2.0.0. The regression occurred when there were multiple instances of a class using `Ember.computed.sort` and caused the sorted value to stop updating. Closes #12212. Closes #12215. Closes #12221. Closes #12516. (cherry picked from commit f05bd2d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrates issues with Ember.computed.sort used on class with multiple instances.
Obviously please don't merge this for now. I expect @stefanpenner will just cherry-pick or squash this into his fix.