Closed
Conversation
Contributor
|
Awesome! 😄 |
Member
|
👍 |
Robdel12
force-pushed
the
add-select-test-helper
branch
from
fb8acca to
0792568
Compare
Contributor
|
☔ The latest upstream changes (presumably #12685) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
I like this, but I do not think we should introduce new helpers in current acceptance tests. Can you add a comment to emberjs/rfcs#119 about this? I think this is best served by a general purpose "select" testing addon, and that RFC should make it pretty trivial to allow this to work from an addon. Thank you for the time you put into this, and I'm sorry for letting it linger so long. I look forward to better testing structure, and I hope we can work together to make this helper a reality... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured I'd give adding the select helper we provide in Emberx-select to ember core a shot.