[BUGFIX beta] Do not rely prototype extensions (objectAt)#12942
Merged
stefanpenner merged 2 commits intoemberjs:masterfrom Feb 10, 2016
btecu:objectAt
Merged
[BUGFIX beta] Do not rely prototype extensions (objectAt)#12942stefanpenner merged 2 commits intoemberjs:masterfrom btecu:objectAt
stefanpenner merged 2 commits intoemberjs:masterfrom
btecu:objectAt
Conversation
Do not use prototype extension for `objectAt`. Related to #9269 and based on the work of @stefanpenner in #10899. If this is acceptable, will continue addressing one extension at a time for quicker merging.
Member
|
@btecu Awesome! Been hoping someone would start moving these over. |
Member
👍 I believe I ran into some strange cycle issues that made it tricky to remove them all, but since then I have landed some fixes to improve it. It might be possible to do today without grief. Keep them coming. |
Member
|
oh, lets make sure We should also consider a future where we expose these as public API, similar to |
Contributor
Author
|
Thanks both! I've added a unit test. |
stefanpenner
added a commit
that referenced
this pull request
Feb 10, 2016
[BUGFIX beta] Do not rely prototype extensions (objectAt)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not use prototype extension for
objectAt.Related to #9269 and based on the work of @stefanpenner in #10899.
If this is acceptable, will continue addressing one extension at a time for quicker merging.