Skip to content

[DOC release] Update get helper documentation, fixes #13080#13082

Closed
irminsul wants to merge 1 commit intoemberjs:masterfrom
irminsul:fix-get-helper-documentation
Closed

[DOC release] Update get helper documentation, fixes #13080#13082
irminsul wants to merge 1 commit intoemberjs:masterfrom
irminsul:fix-get-helper-documentation

Conversation

@irminsul
Copy link

No description provided.

@mixonic
Copy link
Member

mixonic commented Mar 11, 2016

I'm not wild about advertising onclick={{action in our documentation.

I think this is just hiding a bug. <button {{action (mut foo)}}> seems reasonable to support to me.

@irminsul
Copy link
Author

I agree, <button onclick={{action (mut foo) 'bar'}}> isn't very nice. I've just stumbled across the two broken examples in the documentation and thought they should be fixed.

@locks
Copy link
Contributor

locks commented May 13, 2016

For what is worth, <button {{action (action (mut foo))}}> works and I believe it's even somewhere in the Guides?

@homu
Copy link
Contributor

homu commented Aug 31, 2016

☔ The latest upstream changes (presumably #14163) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants