[Glimmer2] Move willDestroyElement tests.#13156
Closed
krisselden wants to merge 1 commit intomasterfrom
Closed
Conversation
krisselden
force-pushed
the
will-destroy-element
branch
from
d4c9f4a to
c477447
Compare
| let willDestroyElementCount = 0; | ||
| let FooBarComponent = Component.extend({ | ||
| didInsertElement() { | ||
| assert.notEqual(this.element.parentNode, null, 'precond component is in DOM'); |
Member
There was a problem hiding this comment.
Is there a reason you moved the assertion into here (as opposed to have the hooks set an outer var and assert as part of the testing flow)? If the hook did not fire, it won't fail the test. The willDestroyElement hook happens to not have this problem because of the counter, but it seems easy for future contributors to accidentally mess that up. The previous "set an outer var" approach seemed better to me
52 tasks
Member
|
This was merged into our branch in #13168 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more a direct port, I'd rather test all the lifecycle hooks, (at least do didInsertElement along with willDestroyElement) for built-ins that can add/remove components.