[DOC release] remove misleading statement#13180
Merged
mixonic merged 1 commit intoemberjs:masterfrom Mar 27, 2016
GavinJoyce:gj/assert-docs
Merged
[DOC release] remove misleading statement#13180mixonic merged 1 commit intoemberjs:masterfrom GavinJoyce:gj/assert-docs
mixonic merged 1 commit intoemberjs:masterfrom
GavinJoyce:gj/assert-docs
Conversation
Member
|
@GavinJoyce can you just edit this to clarify assertion lines are stripped from Ember.js production builds, and make no-op for assertions in application code? |
Member
Author
|
@mixonic updated, thanks |
Member
|
👏 |
webark
added a commit
to webark/ember.js
that referenced
this pull request
Apr 9, 2016
toddjordan
pushed a commit
to toddjordan/ember.js
that referenced
this pull request
Sep 9, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Ember build tools will remove any calls to Ember.assert() when doing a production buildstatement is pretty misleading IMO. I expected that ember-cli would strip them from my app, which isn't the case.