Skip to content

[Glimmer2] Glimmer compiler options#13251

Merged
wycats merged 1 commit intoemberjs:masterfrom
chadhietala:fix-precompiler-option
Apr 5, 2016
Merged

[Glimmer2] Glimmer compiler options#13251
wycats merged 1 commit intoemberjs:masterfrom
chadhietala:fix-precompiler-option

Conversation

@chadhietala
Copy link
Contributor

I think this all that is missing for AST plugins and other options to be used in the glimmer compiler.

This allows for AST plugins and other options to be passed into the
glimmer compiler.
@chadhietala chadhietala force-pushed the fix-precompiler-option branch from cd8f66f to e6df43e Compare April 4, 2016 23:46
@chadhietala
Copy link
Contributor Author

I think I might have to symlink here to make sure both compilers are running the test but would like some 👀 /cc @chancancode @rwjblue @wycats

@chadhietala
Copy link
Contributor Author

Tested this in an app and appears to work. When I mean work, I mean the AST transforms get executed.

@wycats
Copy link
Member

wycats commented Apr 5, 2016

I'm going to merge this but I'm pretty uneasy about making this API feel even more public. Just to be clear, it's emphatically not intended to be a public API, and it will likely break more over time.

We do need a public API for solving the exact problem you have in mind, which we should chat about (so we can make sure we hit your requirements when we write the RFC). In the meantime, caveat emptor.

@wycats wycats merged commit 63d6279 into emberjs:master Apr 5, 2016
@rwjblue
Copy link
Member

rwjblue commented Apr 5, 2016

@wycats this enables the Ember specific AST transforms that enable a number of things via rewrites. This doesn't infer in any way that AST transforms are considered public API (though I do think we should find a way to provide some of this functionality via public API at some point).

@chadhietala chadhietala deleted the fix-precompiler-option branch April 5, 2016 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants