[BUGFIX beta] Use a symbol to detect if an object is a stream.#13290
Merged
mmun merged 2 commits intoemberjs:masterfrom Apr 10, 2016
Merged
[BUGFIX beta] Use a symbol to detect if an object is a stream.#13290mmun merged 2 commits intoemberjs:masterfrom
mmun merged 2 commits intoemberjs:masterfrom
Conversation
Previously, having an `isStream` property on a component would cause us to assume that component was itself a stream. Using an internal symbol allows us to avoid reserving the property `isStream`.
Member
Author
|
@mmun - r? |
Member
|
You rule @rwjblue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, having an
isStreamproperty on a component would cause us toassume that component was itself a stream. Using an internal symbol allows
us to avoid reserving the property
isStream.Fixes #13271.