Skip to content

[BUGFIX release] Fix mouseenter typo in ember-testing helpers#13310

Merged
rwjblue merged 1 commit intoemberjs:masterfrom
jakesjews:master
Apr 12, 2016
Merged

[BUGFIX release] Fix mouseenter typo in ember-testing helpers#13310
rwjblue merged 1 commit intoemberjs:masterfrom
jakesjews:master

Conversation

@jakesjews
Copy link
Contributor

It looks like there was a typo in #12575 mousenter should be mouseenter

@rwjblue
Copy link
Member

rwjblue commented Apr 12, 2016

Great catch! This was just released in v2.5.0 (cut earlier today), and we are in the process of rolling canary -> beta and beta -> release. Can you update commit prefix to be [BUGFIX release] so we can backport into a future v2.5.1?

@jakesjews
Copy link
Contributor Author

No problem!
It looks like there might be another issue I have to fix though. When I run the test in the browser or with ember-cli it passes but it looks like its failing with npm test. Does anything jump out that I'm doing wrong?

@jakesjews jakesjews changed the title [BUGFIX beta] Fix mouseenter typo in ember-testing helpers [BUGFIX release] Fix mouseenter typo in ember-testing helpers Apr 12, 2016
@jakesjews
Copy link
Contributor Author

So after digging into it a bit more it looks like setting enableOptionalFeatures makes the test consistently fail for me. Is there an easy way to find out which flag is causing the problem?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this up into the guard above ( if (!isEnabled('ember-glimmer')) { guard that ends just above here at L450).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rwjblue rwjblue merged commit 3970129 into emberjs:master Apr 12, 2016
rwjblue pushed a commit that referenced this pull request Apr 12, 2016
rwjblue pushed a commit that referenced this pull request Apr 12, 2016
toddjordan pushed a commit to toddjordan/ember.js that referenced this pull request Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants