[Glimmer 2] Allow for null lookups on get to fail gracefully#13317
Merged
chancancode merged 2 commits intoemberjs:masterfrom Apr 13, 2016
Merged
[Glimmer 2] Allow for null lookups on get to fail gracefully#13317chancancode merged 2 commits intoemberjs:masterfrom
get to fail gracefully#13317chancancode merged 2 commits intoemberjs:masterfrom
Conversation
chadhietala
changed the title
chadhietala
changed the title
get to fail gracefully
Member
Member
There was a problem hiding this comment.
I didn't realize we are at the "leaf" of a chain here. In that case, we can just return null here. NULL_REFERENCE is just a POJO whose value and get is hardcoded to always return null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 3 failing tests under
gethelper in #13316