[Glimmer2] Fix class bindings

[asakusuma]

Not sure this is correct way to get the class name out of the binding object.

[krisselden]

const WHITESPACE = /\s+/;

The global flag isn't needed for split, neither is the group.

[stefanpenner]

@krisselden your example includes other things, space\tab\carriage return\new line\vert tab/form feed, which may or may not be expected.

I think the goal is one or more spaces which I think is more accurately expressed as

• / +/
• /[ ]+/ or to be clear we want one or more of a space

but ( )+ seems to imply capturing and g is global, both likely not the intent, and /\s+/ includes other chars, which may or not want to be matched.

[chadhietala]

I'm not sure if this the approach we want to take. After talking @wycats it seems like glimmer needs to expose a refineExpression hook in the environment to compliment refineStatement. This is so that statements don't need to "peek" inside to handle functionality like this. I'm currently trying to figure out how to add the refineExpression hook.

[homu]

☔ The latest upstream changes (presumably #13372) made this pull request unmergeable. Please resolve the merge conflicts.

[asakusuma]

Looks like saucelabs firefox is crapping out

Error: [init({"browserName":"firefox","version":"latest","platform":"","deviceName":"","device-orientation":"","tags":["Saucie","test"],"name":"Saucie tests","public":"public","build":"18176","tunnel-identifier":"18176.6","record-video":true})] The environment you requested was unavailable.

[asakusuma]

Build is passing now

[chadhietala]

Can't you read the parts of the Ref syntax?

[asakusuma]

@chadhietala in this case the object returned from args.named.at('classBinding') only has type and value properties. There's no ref property.

[asakusuma]

@rwjblue I just rebased and now the tests are failing because of a deprecation being thrown as an error.

Uncaught Error: `Ember.Binding` is deprecated. Consider using an `alias` computed property instead.

It's unclear to me if this is expected, and if so, does that mean that classBinding should not be implemented for glimmer?

Looks like this PR introduced the deprecation: #13424

[chadhietala]

@asakusuma It needs to be implemented as Ember.Binding won't be removed till 3.0.0. https://github.com/emberjs/ember.js/pull/13424/files#diff-d50d2452ca8c5f57019c1974e6a3fb52R298

[rwjblue]

All tests for classBinding will have to expectDeprecation.

[asakusuma]

@chadhietala I think we were overcomplicating this. Updated PR is now a lot simpler. Let me know if this is not a public API, but seems public to me.

[krisselden]

This is creating the binding in the wrong scope. It is supposed to be the template scope not the component. Unfortunately the test does not actually cover bindings, just static classes, but doing a quick search of github, this does seemed to be a used feature though undocumented and not tested.

[asakusuma]

This currently won't work with helpers. If we need to support this, we'll need a way to generate a spec from a helper.

[rwjblue]

Thank you @asakusuma!