Skip to content

[BUGFIX beta] Fix positional parameters when used with component helper#13435

Merged
rwjblue merged 1 commit intoemberjs:masterfrom
Serabe:fix/13158
May 2, 2016
Merged

[BUGFIX beta] Fix positional parameters when used with component helper#13435
rwjblue merged 1 commit intoemberjs:masterfrom
Serabe:fix/13158

Conversation

@Serabe
Copy link
Member

@Serabe Serabe commented Apr 30, 2016

Updates positional parameters when component is invoked with the component
helper.

Uncomments the test, as asked in #13158.

Fixes #13158 in htmlbars

@Serabe
Copy link
Member Author

Serabe commented Apr 30, 2016

More comments on this:

  1. The code is not clean, not clean at all, but params and attrs are hard to deal with in htmlbars.
  2. Positional parameters are coming to Glimmer 2 as well ([Glimmer2] Implement positional parameter #13393). They will need no fix when they are finished.
  3. Shall I open a new PR for porting this to LTS?

@rwjblue
Copy link
Member

rwjblue commented May 1, 2016

I do not think we backport this into lts-2-4 branch. My reasoning is basically that this doesn't seem like a regression (as far as I can tell it has never worked)....

@Serabe
Copy link
Member Author

Serabe commented May 1, 2016

It worked in 2.2. Twiddle

Updates positional parameters when component is invoked with the component
helper.

Uncomments the test, as asked in emberjs#13158.
@rwjblue rwjblue merged commit 48f7b81 into emberjs:master May 2, 2016
@rwjblue
Copy link
Member

rwjblue commented May 2, 2016

Thanks @Serabe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants