[BUGFIX beta] Fix positional parameters when used with component helper#13435
Merged
rwjblue merged 1 commit intoemberjs:masterfrom May 2, 2016
Merged
[BUGFIX beta] Fix positional parameters when used with component helper#13435rwjblue merged 1 commit intoemberjs:masterfrom
rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
Member
Author
|
More comments on this:
|
Member
|
I do not think we backport this into lts-2-4 branch. My reasoning is basically that this doesn't seem like a regression (as far as I can tell it has never worked).... |
Member
Author
|
It worked in 2.2. Twiddle |
Updates positional parameters when component is invoked with the component helper. Uncomments the test, as asked in emberjs#13158.
Member
|
Thanks @Serabe! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates positional parameters when component is invoked with the component
helper.
Uncomments the test, as asked in #13158.
Fixes #13158 in
htmlbars