Merged
Conversation
This PR implements positional parameters in Glimmer 2
wycats
force-pushed
the
feature/glimmer-2-positional-params
branch
from
3753281 to
2d29f05
Compare
This refactor turns the args processing into a reference. This pushes some of the triage and validation work upfront to allow for better runtime (especially update time) performance. It also tries to make the positional params feature Pay-As-You-Go by creating specialized objects for the three different cases.
wycats
force-pushed
the
feature/glimmer-2-positional-params
branch
from
2d29f05 to
312b3ea
Compare
chancancode
changed the title
wycats
force-pushed
the
feature/glimmer-2-positional-params
branch
2 times, most recently
from
17eb636 to
f23aa40
Compare
wycats
force-pushed
the
feature/glimmer-2-positional-params
branch
from
f23aa40 to
fb151a5
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased #13393 + #13478 refactored the implementations. This refactor turns the args processing into a reference. This pushes some of the triage and validation work upfront to allow for better runtime (especially update time) performance. It also tries to make the positional params feature Pay-As-You-Go by creating specialized objects for the three different cases.