Skip to content

Ensure top level destroys DOM#13751

Closed
rwjblue wants to merge 1 commit intoemberjs:masterfrom
rwjblue:ensure-top-level-destroy-clears
Closed

Ensure top level destroys DOM#13751
rwjblue wants to merge 1 commit intoemberjs:masterfrom
rwjblue:ensure-top-level-destroy-clears

Conversation

@rwjblue
Copy link
Member

@rwjblue rwjblue commented Jun 26, 2016

Prior to this change, the render nodes are cleared (replaced with <!---->) but not removed from the DOM

/cc @krisselden

@rwjblue
Copy link
Member Author

rwjblue commented Jun 27, 2016

Discussed with @krisselden, and we need to ensure that this isn't running for things other than top level view.

@krisselden
Copy link
Contributor

This should be fixed by #13775

@rwjblue rwjblue closed this Jul 4, 2016
@rwjblue rwjblue deleted the ensure-top-level-destroy-clears branch July 4, 2016 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants