Default queryParams for link-to must have values#14068
Merged
rwjblue merged 2 commits intoemberjs:masterfrom Aug 15, 2016
Merged
Default queryParams for link-to must have values#14068rwjblue merged 2 commits intoemberjs:masterfrom
rwjblue merged 2 commits intoemberjs:masterfrom
Conversation
Member
|
|
Member
|
Thanks for working so hard at this @alisdair! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When transitioning between two routes with query params, if the user interrupts the active transition due to a slow model by visiting a third route with no query params, this causes an exception to be raised.
The root cause is that
link-tohas a default/fallbackqueryParamsof{}, but it needs to have avaluesfield. Otherwise, we passundefinedto the router, which blows up as a result (see #14040).This PR fixes #14010 at the correct level, and adds a better regression test than #14040.
Thanks to @rwjblue and @GavinJoyce for all their help!