Ensure view registry entries can be unregistered properly.#14100
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Aug 19, 2016
Merged
Ensure view registry entries can be unregistered properly.#14100rwjblue merged 1 commit intoemberjs:masterfrom
rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
When the `register` / `unregister` functions were moved from the `ViewSupportMixin` to the renderer, I didn't properly update them to use the provided `view`'s `elementId` and was instead using `this.elementId` (on the renderer) which was obviously undefined. This meant that we were holding on to a reference of all views/components ever created (since they were never being released from the `viewRegistry`). 😭
This was referenced Oct 27, 2016
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
register/unregisterfunctions were moved from theViewSupportMixinto the renderer, I didn't properly update them to use the providedview'selementIdand was instead usingthis.elementId(on the renderer) which was obviously undefined.This meant that we were holding on to a reference of all views/components ever created (since they were never being released from the
viewRegistry). 😭