Skip to content

Provide better error for non-resolving quoteless action#14121

Merged
rwjblue merged 1 commit intoemberjs:masterfrom
HeroicEric:better-quoteless-error-assertion
Aug 24, 2016
Merged

Provide better error for non-resolving quoteless action#14121
rwjblue merged 1 commit intoemberjs:masterfrom
HeroicEric:better-quoteless-error-assertion

Conversation

@HeroicEric
Copy link
Member

This makes a slight improvement to the assertion that is raised when a
quoteless path is used to specify an action by including additional
information to help track down which {{action}} invocation is
triggering the assertion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping somebody might point out a better way to do this 😄

There is another area that is doing something similar #13684 (diff)

This makes a slight improvement to the assertion that is raised when a
quoteless path is used to specify an action by including additional
information to help track down which `{{action}}` invocation is
triggering the assertion.
@HeroicEric HeroicEric force-pushed the better-quoteless-error-assertion branch from 6fa8bfa to 5f1bcec Compare August 24, 2016 01:53
@rwjblue rwjblue merged commit 0299686 into emberjs:master Aug 24, 2016
@rwjblue
Copy link
Member

rwjblue commented Aug 24, 2016

Thanks @HeroicEric!

@HeroicEric HeroicEric deleted the better-quoteless-error-assertion branch August 24, 2016 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants