[DOC Beta]add docs to helper files for glimmer 2#14200
[DOC Beta]add docs to helper files for glimmer 2#14200rwjblue merged 1 commit intoemberjs:masterfrom
Conversation
| /** | ||
| @module ember | ||
| @submodule ember-glimmer | ||
| @public |
There was a problem hiding this comment.
I don't think @public belongs in this one
|
☔ The latest upstream changes (presumably #14209) made this pull request unmergeable. Please resolve the merge conflicts. |
toddjordan
force-pushed
the
glimmer2-api-doc-helpers
branch
2 times, most recently
from
2ab3f67 to
75b2d8a
Compare
toddjordan
force-pushed
the
glimmer2-api-doc-helpers
branch
from
75b2d8a to
424343c
Compare
|
Unsure where to put docs from the following files (no equivalent in the ember-glimmer package). Could use some guidance on where to put the docs for these.
|
toddjordan
force-pushed
the
glimmer2-api-doc-helpers
branch
from
1acf4e9 to
054b77e
Compare
packages/ember-glimmer/lib/index.js
Outdated
| @@ -1,3 +1,85 @@ | |||
| /** | |||
|
|
|||
| [Glimmer](https://github.com/tildeio/glimmer) is a [Handlebars](http://handlebarsjs.com/) | |||
There was a problem hiding this comment.
Updated the documentation to point at glimmer instead of htmlbars. Combined the ember-htmlbars and ember-templates documentation into just ember-glimmer. Need some confirmation that this is what is desired
toddjordan
force-pushed
the
glimmer2-api-doc-helpers
branch
from
9513dbf to
2cffcf4
Compare
toddjordan
changed the title
|
@toddjordan - I guess we can add the docs inline in |
|
ok, did that |
toddjordan
force-pushed
the
glimmer2-api-doc-helpers
branch
from
2cffcf4 to
5b29c54
Compare
packages/ember-glimmer/lib/index.js
Outdated
| */ | ||
|
|
||
| /** | ||
| A method of subscribing to a stream which is safe for use with a non-stream |
There was a problem hiding this comment.
not sure that Ember.stream.subscribe even exists, but it was public. Any thoughts?
There was a problem hiding this comment.
No, it was only public behind a feature flag (was never exposed without flag enabled, and the flag was never enabled). ✂️ all references to "streams"
toddjordan
force-pushed
the
glimmer2-api-doc-helpers
branch
from
5b29c54 to
6f6e014
Compare
|
@rwjblue I believe a 2.8 docs release is happening soon (today?) Do you think this is ready? And should this be merged into something other than master? EDIT: nevermind... Got my 2.8 and 2.9 mixed up :-P false alarm |
|
☔ The latest upstream changes (presumably #14231) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Sorry about this needing a rebase, I missed the last round of fixes before I merged #14231. |
|
that's ok. I'll do that now |
toddjordan
force-pushed
the
glimmer2-api-doc-helpers
branch
from
6f6e014 to
3d95fbf
Compare
toddjordan
force-pushed
the
glimmer2-api-doc-helpers
branch
from
3d95fbf to
31a8d68
Compare
toddjordan
force-pushed
the
glimmer2-api-doc-helpers
branch
4 times, most recently
from
4400b6a to
2873c8e
Compare
|
☔ The latest upstream changes (presumably #14267) made this pull request unmergeable. Please resolve the merge conflicts. |
toddjordan
force-pushed
the
glimmer2-api-doc-helpers
branch
from
2873c8e to
a35b84d
Compare
Additional updates minor tweaks combined htmlbars and ember-templates doc fix some code samples Added some missing public docs to index.js remove stream doc fix merge/rebase blunder update import missed on merge
toddjordan
force-pushed
the
glimmer2-api-doc-helpers
branch
from
158cf6c to
31c015b
Compare
|
Thank you! |
3 participants
Part of #14166
Stab a converting htmlbar api documentation for glimmer 2