Merged
Conversation
added 14 commits
September 4, 2016 22:01
Normally, this is setup by a booted app, but in this case we are building without a "real" app. This allows us to avoid errors when looking up `controller`s and `route`s (that get an injection from `router:main`).
Use the shared one in internal-test-helpers instead.
This was referenced Sep 5, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use relative imports for importing things within a given package, and the entry point modules (i.e.
ember-metal/index/ember-metal) for imports in another package.Also migrates a few scattered test helpers into a single location (in
internal-test-helpers).