Skip to content

[CLEANUP] Move TestCase helpers to internal-test-helpers#14429

Merged
rwjblue merged 1 commit intoemberjs:masterfrom
trentmwillis:test-case-helpers
Oct 6, 2016
Merged

[CLEANUP] Move TestCase helpers to internal-test-helpers#14429
rwjblue merged 1 commit intoemberjs:masterfrom
trentmwillis:test-case-helpers

Conversation

@trentmwillis
Copy link
Member

Follow up to #14428. Moves the TestCase and associated helpers into internal-test-helpers.

A couple notes:

  1. To avoid needing to re-write all the imports in the glimmer test suite, I opted to re-export any moved helpers in the same files. If we want to clean that up, I think it should be done in a follow up PR.
  2. I standardized all the "test" classes to have the suffix TestCase; including renaming the base class to AbstractTestCase. If this is undesirable, I can switch it back (mainly did it so that everything is consistent).

cc/ @rwjblue

@rwjblue rwjblue merged commit 8cb2107 into emberjs:master Oct 6, 2016
@rwjblue
Copy link
Member

rwjblue commented Oct 6, 2016

Thanks @trentmwillis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants